Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
202 stars 31 forks source link

Dismissing "Cannot fix object without a name" dialog with an escape hangs Ride #160

Closed JohnScholes closed 7 years ago

JohnScholes commented 7 years ago

Describe the issue you are having

as above

Did you connect to an already running interpreter or start the interpreter from RIDE?

Start an interpreter

How do you reproduce the issue?

      )ed foo
Type ! following the foo in the edit window.
Type Esc : "Cannot fix object without a name"
Type Esc :  dialog disappears
Now all bets are off
...
Force Quit of Dyalog app.

Paste the contents of Help → About (Shift+F1)

IDE: Version: 4.0.2801 Platform: MacIntel Date: 2017-05-05 15:12:33 +0100 Git commit: 1f2c48118cb3919c6b2fc48a93df4b84fbfbbf95 Preferences:{ "autocompletion":"0", "indentOnOpen":"0", "kbdLocale":"en_US_Mac", "lineNums":"0", "pfkeys":"[\"\",\"\",\"\",\"\",\"\",\"\",\"\",\"\",\"\",\"\",\")reset)save\",\"\",\"\"]", "squiggleTips":"0", "valueTips":"0", "zoom":"5" }

Interpreter: Version: 16.0.29853 Platform: Mac-64 Edition: Unicode/64 Date: May 6 2017 at 01:17:57

flouc001 commented 7 years ago

I have changed the mechanic of the dialog boxes created by the interpreter to not allow "Esc" or "X" closing. You must acknowledge the dialog using one of the buttons. This can still be done with the keyboard and it provides the interpreter with information it needs to continue.

lstefano71 commented 7 years ago

I beg you... don't do this. Conventions, not matter how annoying for the developer, as long as they are recognised as universal conventions, must be respected. "Esc" to close a modal dialog box is even today (I may say: especially today, after 30+ years of history of UX) a must.

e9gille commented 7 years ago

Apart from Stefano's comment on the behavior of dialog boxes I can see that on the nix version RIDE receives an OptionsDialog event with the message above. This event is missing in the win version.