Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
202 stars 31 forks source link

Glyph top bar doesn't support as many spaces as I want. #307

Closed GolfingSuccess closed 6 years ago

GolfingSuccess commented 6 years ago

Describe the issue you are having

In RIDE 4.0, you can see that the glyphs at the top bar can be moved around. This is handy if you want a different grouping than the default. Unfortunately, there is a finite number of spaces in the top bar you can move around, so not all groupings are possible, and I feel like this could be limiting for some.

Did you connect to an already running interpreter or start the interpreter from RIDE?

Started from RIDE.

How do you reproduce the issue?

It's not something you reproduce, it's an issue with the interface.

Paste the contents of Help → About (Shift+F1)

IDE: Version: 4.0.2860 Platform: Linux x86_64 Date: 2017-08-03 09:42:41 +0100 Git commit: ea7171c622602555be0e6dfb106ed73f6261f7d7 Preferences:{ "kbdLocale":"en_US", "lbarOrder":"← +-×÷*⍟⌹○!? |⌈⌊⊥⊤⊣⊢ =≠≤<>≥≡≢ ∨∧⍲⍱ ↑↓⊂⊃⊆⌷⍋⍒ ⍳⍸∊⍷∪∩~ /\⌿⍀ ,⍪⍴⌽⊖⍉ ¨⍨⍣.∘⍤@ ⍞⎕⍠⌸⌺⌶⍎⍕ ⋄⍝→⍵⍺∇& ¯⍬", "selectedExe":"/opt/mdyalog/16.0/64/unicode/mapl" }

Interpreter: Version: 16.0.30863 Platform: Linux-64 Edition: Unicode/64 Date: Aug 31 2017 at 02:58:43

abrudz commented 6 years ago

Right, in the IDE, you can right click and select "Insert Space Before". Maybe a solution would be to always ensure a single trailing space. Then if the user moves that somewhere, we add another space at the end. And if the user moves a space to the end, we remove one, so only one trailing space remains.

ngn commented 6 years ago

that was the case before, likely changed with https://github.com/Dyalog/ride/commit/67c3a3cb5fbe464737a73d28de2b17b68fb95493#diff-b6f25b101aa100341900265a9d3a38abL381

GolfingSuccess commented 6 years ago

@abrudz except that's not the case here.

abrudz commented 6 years ago

@GolfingSuccess The IDE is the default Windows desktop interface.

GolfingSuccess commented 6 years ago

@abrudz But I'm not using Windows.

e9gille commented 6 years ago

@ngn spot on what I was going to say. I had not noticed that the feature had been lost. I'm sure it wasn't intentional.

I suspect the attempt was to add attributes to enable more detailed styling of separators. I'll add it back in for now while we review the suggestions from @abrudz (#264 #267)

GolfingSuccess commented 6 years ago

@e9gille RIDE doesn't seem to have been packaged with the temporary fix yet, just re-installed RIDE and found out no trailing space or "Insert space" option.

e9gille commented 6 years ago

Sorry, I fixed it in the master branch only. I'll see if we can get a release out for v4.0 anytime soon.

GolfingSuccess commented 6 years ago

Oh, that's alright. Hope it's packaged soon! Thanks in advance.