Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
206 stars 32 forks source link

Edit window > Search bar > Find field > confusing "match whole word" option #458

Closed FionaDyalog closed 6 years ago

FionaDyalog commented 6 years ago

Describe the issue you are having

Edit window > Search bar > Find field offers a filter of "match whole word". This is very confusing with APL. As far as I can tell, a word is defined as delimited by spaces or any of the characters (){}[];:,. which doesn't really make sense from an APL perspective. I believe it would be less confusing to a user to remove this option.

Did you connect to an already running interpreter or start the interpreter from RIDE?

irrelevant

How do you reproduce the issue?

Edit window > Search bar > Find field. Play with the "match whole word" filter.

Paste the contents of Help → About (Shift+F1)

IDE: Version: 4.1.3353 Platform: Win32 Date: 2018-06-15 21:21:46 +0200 Git commit: fd94d5676e955ec67cf10c19902a10b15eeaa7f8

Interpreter: Version: 17.0.33293 Platform: Windows-64 Edition: Unicode/64 Date: Jun 3 2018 at 20:03:03

DyalogRichard commented 6 years ago

I would imagine that having the option, without it understanding APL semantics, is better than not having it at all.

The exact same problem came up with the ODE recently (which switched to using PCRE rather than a bespoke search engine) - http://mantis.dyalog.com/view.php?id=15422. The solution was to search without any "match whole word" option and then to check and, if necessary, discard matches that did not conform (if text precedes or follows it must be a non-APL word char; the match itself must consist only of APL word chars).

dyaandys commented 6 years ago

.. and it’s quite important that Quad is considered as part of a word .. we even achieved that on the forums ..

From: Richard Smith notifications@github.com Sent: 18 June 2018 14:41 To: Dyalog/ride ride@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Dyalog/ride] Edit window > Search bar > Find field > confusing "match whole word" option (#458)

I would imagine that having the option, without it understanding APL semantics, is better than not having it at all.

The exact same problem came up with the ODE recently (which switched to using PCRE rather than a bespoke search engine) - http://mantis.dyalog.com/view.php?id=15422. The solution was to search without any "match whole word" option and then to check and, if necessary, discard matches that did not conform (if text precedes or follows it must be a non-APL word char; the match itself must consist only of APL word chars).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Dyalog/ride/issues/458#issuecomment-398057500 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKkCEsHx0UDIUIFozPtUUbG92CVofnbvks5t963fgaJpZM4UrwN9 .

e9gille commented 6 years ago

The list of word separators has been improved and now includes all primitives (except for ) plus the following:

()[]{}%£#;:'"`$^