search

Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
198 stars 29 forks source link

confirm session close #7

Closed ngn closed 8 years ago

ngn commented 8 years ago

In the old IDE closing the session window is confirmed with a dialog because it may cause loss of data. RIDE should do the same.

On behalf of @JohnScholes

ngn commented 8 years ago

I tested this -- no window.onfocus or window.onblur events are triggered. This could be due to any of Chromium, NW.js, or OSX.

JohnScholes commented 8 years ago

Strange because I get the warning if I use CMD+w to close an edit window in which I have made a change:

On 31 Mar 2016, at 16:21, ngn notifications@github.com wrote:

I tested this -- no window.onfocus or window.onblur events are triggered. This could be due to any of Chromium, NW.js, or OSX.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Dyalog/ride/issues/7#issuecomment-203984457

JohnScholes commented 8 years ago

Excellent, Thank you.

On 8 Apr 2016, at 14:36, ngn notifications@github.com wrote:

Closed #7 https://github.com/Dyalog/ride/issues/7 via 9933d0c https://github.com/Dyalog/ride/commit/9933d0c7da9bc12712e5f4c90672699a5273569f.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Dyalog/ride/issues/7#event-620135242