DyegoAV / slimstat

Automatically exported from code.google.com/p/slimstat
GNU General Public License v2.0
1 stars 0 forks source link

Paths File Enhancement #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
For easier reading, I'd added the corresponding date before time into the 
"Paths" file row like this (file "paths.php" ligne #103):

echo $dy.'/'.$mo.' '.( ( $start_ts == $end_ts ) ? $start_ts : 
$start_ts.'–'.$end_ts );

Note. Cause a new entry is added, the css styles sheet need to be changed 
accordingly

Original issue reported on code.google.com by patrick....@gmail.com on 16 Jan 2010 at 8:19

GoogleCodeExporter commented 9 years ago
I'm not really sure about this. I don't want to make that column wider, because 
then there's less room for 
everything else. An alternative might be to put the date in the 'accent' row, 
and then have the time in the row 
below.

But I'm not sure that the date is needed, because it's almost certainly going 
to be today's date (unless you are 
looking at it just after midnight).

Original comment by step...@wettone.com on 22 Jan 2010 at 12:42

GoogleCodeExporter commented 9 years ago
Hi.

Sure you're right if you don't add a "select number row to display" in the page 
"Paths" 
as shown in the screen capture.

I'm currently adapt your code to add this feature... but I can't stay on the 
page url ( /?
paths ) when I submit my form (event if I add an action="?/paths" )
My form is a get method that I can read within a session to change the "LIMIT" 
value 
in the query statment.

Best regards,
Patrick

Original comment by patrick....@gmail.com on 22 Jan 2010 at 12:59

GoogleCodeExporter commented 9 years ago
Here's a new version of paths.php that shows the date. Can you try it out and 
let me
know what you think?

Original comment by step...@wettone.com on 28 Jan 2010 at 3:32

Attachments:

GoogleCodeExporter commented 9 years ago
Hi.

I'd tried your patch but it seems that I see only one date (in the first line 
row) not for 
the other one.

I send you mine if you want to try it.

Cheers,
Patrick.

Original comment by patrick....@gmail.com on 28 Jan 2010 at 10:00

Attachments:

GoogleCodeExporter commented 9 years ago
It only shows the date the first time because I didn't want it to repeat 
itself. I think it's obvious enough that the 
date is the same each time.

If you want to see the date every time, change line 105 to:

if ( $dy_label != $prev_dy || $prev_dy == '' ) {

I will give yours a try now.

Original comment by step...@wettone.com on 28 Jan 2010 at 10:55

GoogleCodeExporter commented 9 years ago
I've made a new paths.php that I think merges the best bits of yours and mine, 
plus a couple of small bug fixes. 
I'm going to check it in now.

Original comment by step...@wettone.com on 29 Jan 2010 at 3:03

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r85.

Original comment by step...@wettone.com on 29 Jan 2010 at 3:03

GoogleCodeExporter commented 9 years ago
Hi.
Fantastic. Your're the best. I love this revision :D

Best regards,
Patrick.

Original comment by patrick....@gmail.com on 29 Jan 2010 at 5:29