search

DyfanJones / RAthena

Connect R to Athena using Boto3 SDK (DBI Interface)
https://dyfanjones.github.io/RAthena/
Other
35 stars 6 forks source link

RAthena 1.9.0 cran submission delay #108

Closed DyfanJones closed 4 years ago

DyfanJones commented 4 years ago

Due to recent changes in R-4.0.0 \donttest now run. This causes a problem with most examples, as they require credentials. This results in the R CMD checks failing on Rhub servers. I have reached out to the cran (cran-submissions@r-project.org) asking advice for how the examples should be set up going forward.

To prevent spamming the cran with multiple package submission attempts, this release will be slightly delayed depending on response from cran submissions.

DyfanJones commented 4 years ago

Email sent to cran submissions:

Hi all, I am the author of an api package call "RAthena". In this package I have several examples around how to connect to AWS Athena. These examples require credentials for them to run. In the past I have used "\donttest" recommend by cran support team. However due to the recent changes in \donttest in R 4.0.0:

R CMD check --as-cran now runs \donttest examples (which are run by example()) instead of instructing the tester to do so. This can be temporarily circumvented during development by setting environment variable _R_CHECK_DONTTESTEXAMPLES to a false value. Should I change these examples to "\dontrun" so that R CMD check doesn't run these examples?

I am asking as I am close to releasing the next version of the package and would like some advice in this matter.

DyfanJones commented 4 years ago

Cran response:

Yes, code you expect a user can execute but is too long to check can go into \dontest but code the user cannot execute (i.e. due to missing credentials) should go into \dontrun

Best, Uwe Ligges

DyfanJones commented 4 years ago

Will convert all examples that need credentials to be in \dontrun following cran's advice.

DyfanJones commented 4 years ago

This issue has been fixed with latest