search

DyfanJones / noctua

Connect R to Athena using paws SDK (DBI Interface)
https://dyfanjones.github.io/noctua/
Other
45 stars 5 forks source link

integrate sql_create_date into dplyr_integration.R #108

Closed OssiLehtinen closed 3 years ago

DyfanJones commented 3 years ago

It is weird that codecov isn't picking up the new tests 🤔 we are calling the new methods directly with an expected result. how strange.

OssiLehtinen commented 3 years ago

It is weird that codecov isn't picking up the new tests 🤔 we are calling the new methods directly with an expected result. how strange.

My first suspicion would be that I have done something silly here, but haven't spotted anything so far.

DyfanJones commented 3 years ago

I can't see anything wrong with your code/ unit test. I will spend sometime trying to fix the code coverage after this PR. It isn't a high priority but more of a nice to have :D

DyfanJones commented 3 years ago

hi @OssiLehtinen, do you have anytime to update the link in the news.md? Happy to make the correction myself if you are snowed under :)

OssiLehtinen commented 3 years ago

Urgh, 'snowed under' sounds about right... Fixed the link now.

DyfanJones commented 3 years ago

Thanks @OssiLehtinen for your contribution. I will merge this PR now :D