DyfanJones / noctua

Connect R to Athena using paws SDK (DBI Interface)
https://dyfanjones.github.io/noctua/
Other
45 stars 5 forks source link

Prevent Noctua from printing Data Scanned -information #178

Closed vhpietil closed 2 years ago

vhpietil commented 2 years ago

Is there a way to prevent Noctua from printing Data scanned information?

DyfanJones commented 2 years ago

Currently no, it was an previous feature request so it was added, however I should of added a method to make it quiet. Happy to add it in if you like :)

vhpietil commented 2 years ago

I would be very happy if there was an option to switch it off instead of using suppressMessages in every query :)

DyfanJones commented 2 years ago

So something like this:

remotes::install_github("dyfanjones/noctua", ref="verbose")
library(DBI)
library(noctua)

con <- dbConnect(athena())

dbGetQuery(con, "select * from iris limit 5")
#>    sepal_length sepal_width petal_length petal_width species
#> 1:          5.1         3.5          1.4         0.2  setosa
#> 2:          4.9         3.0          1.4         0.2  setosa
#> 3:          4.7         3.2          1.3         0.2  setosa
#> 4:          4.6         3.1          1.5         0.2  setosa
#> 5:          5.0         3.6          1.4         0.2  setosa

noctua_options(verbose = T)

dbGetQuery(con, "select * from iris limit 5")
#> Info: (Data scanned: 3.63 KB)
#>    sepal_length sepal_width petal_length petal_width species
#> 1:          5.1         3.5          1.4         0.2  setosa
#> 2:          4.9         3.0          1.4         0.2  setosa
#> 3:          4.7         3.2          1.3         0.2  setosa
#> 4:          4.6         3.1          1.5         0.2  setosa
#> 5:          5.0         3.6          1.4         0.2  setosa

Created on 2022-01-13 by the reprex package (v2.0.1)

Currently not sure to have verbose set to FALSE for default or have the user switch to FALSE if they don't like the extra information.

vhpietil commented 2 years ago

Something like that would be nice

DyfanJones commented 2 years ago

Should all information message be optionally turned off? 🤔 Would make it consistent across the package. If that is the case then can leave the default package verbose as TRUE and let the user turn it off.

vhpietil commented 2 years ago

I guess it could be all information messages or none.

On Thu, Jan 13, 2022 at 2:34 PM Larefly @.***> wrote:

Should all information message be optionally turned off? 🤔 Would make it consistent across the package. If that is the case then can leave the default package verbose as TRUE and let the user turn it off.

— Reply to this email directly, view it on GitHub https://github.com/DyfanJones/noctua/issues/178#issuecomment-1012096742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZYAA4YT3PGMLZIBLUECNLUV3BGTANCNFSM5L3P6B3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

DyfanJones commented 2 years ago

Closing this ticket as version 2.5.0 has been pushed to the cran