Release noctua 2.5.0 - Githubissues

DyfanJones / noctua

Connect R to Athena using paws SDK (DBI Interface)

https://dyfanjones.github.io/noctua/

Other

45 stars 5 forks source link

Release noctua 2.5.0 #180

Closed DyfanJones closed 2 years ago

DyfanJones commented 2 years ago

Prepare for release:

[x] Check current CRAN check results
[x] Polish NEWS
[x] urlchecker::url_check()
[x] devtools::check_rhub(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always", LIBARROW_BINARY="true"))
[x] devtools::check_win_devel()
[x] rhub::check_for_cran(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always", LIBARROW_BINARY="true"))
[x] Update cran-comments.md

Submit to CRAN:

[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted 🎉
[x] usethis::use_github_release()
[ ] Finish blog post

DyfanJones commented 2 years ago

checking for detritus in the temp directory ... NOTE Found the following files/directories: 'lastMiKTeXException'

https://builder.r-hub.io/status/noctua_2.5.0.tar.gz-a1c4f3a7f7744094a278070ec5f37807

DyfanJones commented 2 years ago

RAthena unit test failing on the cran: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/noctua-00check.html

Unit test helper function output_test_data(size, test_file) used to create test data is causing the issue.

Cran maintianers have asked to have test using the R-devel or to set environmental variables.

Please see the CRAN results page for the package. Reproduction needs a fully up-to-date version of R-devel, or to use

setenv _R_CHECK_LENGTH_1CONDITION abort,verbose setenv _R_CHECK_LENGTH_1LOGIC2 abort,verbose

DyfanJones commented 2 years ago

Prepare for release:

[x] Check current CRAN check results
[x] Polish NEWS
[x] urlchecker::url_check()
[x] devtools::check_rhub(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always", LIBARROW_BINARY="true",_R_CHECK_LENGTH_1_CONDITION_="abort,verbose",_R_CHECK_LENGTH_1_LOGIC2_="abort,verbose"))
[x] devtools::check_win_devel()
[x] rhub::check_for_cran(env_vars=c("R_COMPILE_AND_INSTALL_PACKAGES" = "always", "LIBARROW_BINARY"="true","_R_CHECK_LENGTH_1_CONDITION_"="abort,verbose","_R_CHECK_LENGTH_1_LOGIC2_"="abort,verbose"))
[x] Update cran-comments.md

Submit to CRAN:

[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted 🎉
[x] usethis::use_github_release()
[ ] Finish blog post