search

DyfanJones / s3fs

Access Amazon Web Service 'S3' as if it were a file system. File system 'API' design around R package 'fs'
https://dyfanjones.github.io/s3fs/
Other
41 stars 1 forks source link

Inconsistent result of s3fs::s3_dir_create with fs::dir_create #28

Closed reisfe closed 1 year ago

reisfe commented 1 year ago

When the directory already exists, fs::dir_create ignores it and returns the path(s) to the directory(ies), while s3fs::s3_dir_create returns the string "Directory already exists in AWS S3".

If the goal is to make code written using the fs package portable to the s3fs than the behavior of the functions should be as close as possible.

Also, returning a string is not the most common behavior in R. A condition should be raised, either error, warning or message.

DyfanJones commented 1 year ago

That is a fair point, I will look at implementing improvements after completing paws performance https://github.com/paws-r/paws/pull/621

DyfanJones commented 1 year ago

In the meantime I welcome any PRs :) they help me greatly when I judge my open source packages 😄

DyfanJones commented 1 year ago

Sorry for the delay in this. PR #30 addresses issue. I will release it to the cran shortly

reisfe commented 1 year ago

Great! Thank you. (And thank you for the great package.)

DyfanJones commented 1 year ago

Closing as s3fs 0.1.4 has been released to the cran