fix: handle hex colors without a preceeding # and refactor - Githubissues

Dygmalab / Bazecor

Graphical configurator for Dygma Products

https://dygma.com/

GNU General Public License v3.0

403 stars 90 forks source link

fix: handle hex colors without a preceeding # and refactor #916

Closed lbrooks closed 4 weeks ago

lbrooks commented 1 month ago

Two edge cases for this two functions would result in NaN being contained within the returned color matrix:

Supplying a hex color string without a preceeding # Supplying a string that was not in the hex or rgb color format.

This PR covers those two cases by:

Supporting hex colors without a preceeding #
Defaults to black if the input string is neither a hex or rgb color

Additionally this PR also

Eliminates the double call to parseInt when supplying a hex color
Added test coverage
Refactored out the common used method to de-duplicate