search

Dygmalab / Raise-Firmware

Firmware for the Dygma Raise Keyboard, it uses a Open source Firmware called Kaleidoscope from http://Keyboard.io
GNU General Public License v3.0
44 stars 16 forks source link

Add HostPowerManagement plugin #9

Closed HomerSp closed 3 years ago

HomerSp commented 3 years ago

This PR simply adds the HostPowerManagement plugin to turn on or off the LEDs when resuming or suspending respectively.

Depends on Kaleidoscope PR: https://github.com/Dygmalab/Kaleidoscope/pull/3

AlexDygma commented 3 years ago

Great job as always Homer! :)

lets hope that with this we will start to make the keyboard behave more as it should!

HomerSp commented 3 years ago

Thanks! I had sort of half forgotten about this since it's been two months with no input, but I'm assuming you've been busy with the next bazecor and the freeze fixes :)

By the way, as I said in the OP this PR won't actually do anything without https://github.com/Dygmalab/Kaleidoscope/pull/3 or similar since the SAMD code doesn't support usb suspend or resume. So if you want it to behave as expected you'll need to test with that too :)

AlexDygma commented 3 years ago

Thanks! I had sort of half forgotten about this since it's been two months with no input, but I'm assuming you've been busy with the next bazecor and the freeze fixes :)

By the way, as I said in the OP this PR won't actually do anything without Dygmalab/Kaleidoscope#3 or similar since the SAMD code doesn't support usb suspend or resume. So if you want it to behave as expected you'll need to test with that too :)

Hahaha you're right! i forgot to merge your other pull request before release, i will update that now :)