search

Dykam / tabbychat

TabbyChat chat mod for Minecraft
16 stars 0 forks source link

Text wrapping happens when entering the text, not when rendering. #29

Closed Dykam closed 9 years ago

Dykam commented 10 years ago

Example

mattmess1221 commented 10 years ago

For me, it only happens when I change the size of the chat box. New messages appear as expected.

Dykam commented 10 years ago

Yes, that is indeed the case. Which I meant. I don't recall if it resizes it when resizing in 1.10, but I think it did. This fix can probably be integrated with the fix for #28.

mattmess1221 commented 10 years ago

Yes, this was in 1.10. This will likely get low priority.

ghost commented 10 years ago

I believe the issue is directly related to the timestamps before the chat message. I find that the warping that does happen, while does exceed the edge of the defined area, does stop after about the same length of characters as the Timestamp preceding every message.

http://i.imgur.com/XZMw5D6.png BAI1

mattmess1221 commented 10 years ago

I have timestamps disabled and it still does that.

On Thu, Feb 27, 2014 at 4:42 PM, BAI1 notifications@github.com wrote:

I believe the issue is directly related to the timestamps before the chat message. I find that the warping that does happen, while does exceed the edge of the defined area, does stop after about the same length of characters as the Timestamp preceding every message.

http://i.imgur.com/XZMw5D6.png BAI1

Reply to this email directly or view it on GitHubhttps://github.com/Dykam/tabbychat/issues/29#issuecomment-36295024 .

mattmess1221 commented 10 years ago

Anyway, fixed.

Dykam commented 10 years ago

It still happens for me on a fresh build. Wide window, long sentence, resize window to make it shorter than the sentence, and it sticks past the window.

mattmess1221 commented 10 years ago

What I fixed was the issue @BAI1 mentioned, then.

Brottweiler commented 10 years ago

Is this related to this issue? I think when there is room for a word, but that words happens to be too long, it goes outside the border

tehface commented 10 years ago

my text over shoots the border of tabby chat like above picture but it keeps on going so yea there's no text wrapping

mattmess1221 commented 9 years ago

I discovered a temporary fix. When this happens, just fiddle with some vanilla chat settings. Mainly chat width. It will cause the chat to be refreshed.

mattmess1221 commented 9 years ago

Fixed via https://github.com/killjoy1221/tabbychat/commit/8b92c579ed2e120cf744843ce9c6c7817d670d8d