search

Dykam / tabbychat

TabbyChat chat mod for Minecraft
16 stars 0 forks source link

Support for client-side Forge commands #38

Closed RoyCurtis closed 10 years ago

RoyCurtis commented 10 years ago

Forge allows for client-side commands to be registered using ClientCommandHandler.instance.registerCommand(command);.

This is for mods that provide local client functionality through commands (e.g. Ingame XML Info and one of my own) even on multiplayer. However, Tabbychat seems to send chat directly to the server, bypassing Forge's ClientCommandHandler and thus preventing such commands from working.

Sidenote: I hope this feature request is appropriate whilst 1.7.2 TabbyChat is still a WIP. I have been following development and am glad to see TC still being kept up-to-date.

mattmess1221 commented 10 years ago

What's the mod you're using that does this? I know of some mods that register commands, but they're not updated yet. I also think it's the server that registers commands. I'm not familiar with the client-side commands.

Dykam commented 10 years ago

I guess we have to look into the base class, to see if we are bypassing a forge modification, or a change in vanilla behavior.

mattmess1221 commented 10 years ago

I have a fix written up, but I need to test it before I commit and push. What's the name of the mod you're using?

RoyCurtis commented 10 years ago

Sorry for the delayed response;

Hope this helps!

Edit: Here is a build of ShopGuideCollector for testing

mattmess1221 commented 10 years ago

Thanks for the links. I have it mostly fixed, but Gradle won't reobf my reference to ICommandSender.class

I'll go ahead and commit it now and maybe we can figure it out later.