search

Dykam / tabbychat

TabbyChat chat mod for Minecraft
16 stars 0 forks source link

not all links work #43

Closed tsudeily closed 10 years ago

tsudeily commented 10 years ago

Not every link works.. Ex: http://www.google.com works

www.google.com does not google.com does not.

Dykam commented 10 years ago

Did you check if it differs from vanilla? As far as I am aware the server determines entirely what is a link and what isn't.

We only process text which has annotations like "open this when clicking" and "show that when hoveren" .

tsudeily commented 10 years ago

Well I fill silly now. No vanilla doesn't allow www.google.com to work

Sorry for wasting your time. :\

mattmess1221 commented 10 years ago

It's hard to verify links if it doesn't have a http:// in front of it.

@Dykam In 29b7c0c4035e0d7bae1f089d86c84581aa1dfd07, I added the ability to click links without server assistance.

Dykam commented 10 years ago

@killjoy1221, what does this feature add? More extensive parsing? Doesn't it desync the server from the client, click-wise? The server can make any text a link.

mattmess1221 commented 10 years ago

It just attempts to parse a url if there's no click event. If it fails, it stops there.

mattmess1221 commented 10 years ago

Closing this. If you want this done, write it yourself and do a PR.