search

DylanPiercey / local-devices

🔮 Find devices connected to the current local network.
MIT License
139 stars 27 forks source link

chore: updated (dev)Dependencies and node version #18

Closed natterstefan closed 4 years ago

natterstefan commented 4 years ago

FYI: Node 8 reaches EOL on December 2019 (https://github.com/nodejs/Release#release-schedule)

natterstefan commented 4 years ago

@DylanPiercey most likely this should be a breaking change because we change the required node-version. What do you think?

DylanPiercey commented 4 years ago

Yeah this should be a major. That is fine with me though.

natterstefan commented 4 years ago

@DylanPiercey perfect, shall we deploy the current unreleased changes with this new major or as a 2.x feature, before creating this major? https://github.com/DylanPiercey/local-devices/blob/master/CHANGES.md#unreleased.

DylanPiercey commented 4 years ago

Sorry for the delay. I think let's just go ahead and release the unreleased changes with the next major.

Would you like to do the release?

natterstefan commented 4 years ago

@DylanPiercey easy, then let's do it all together. Sure, I can do it. Do you mean on npm and/or here?

DylanPiercey commented 4 years ago

Both 😄

natterstefan commented 4 years ago

:D

Sure, I just need publish rights on npm, please. Here's my user: https://www.npmjs.com/~natterstefan.

DylanPiercey commented 4 years ago

Added! Thanks 😄

natterstefan commented 4 years ago

Thank you, will publish it in a few minutes.