DylanPiercey / local-devices

🔮 Find devices connected to the current local network.
MIT License
140 stars 27 forks source link

NPM Publish to include windows support? #19

Closed HenrikJoreteg closed 5 years ago

HenrikJoreteg commented 5 years ago

Hello, @DylanPiercey! thanks for this great module, I was about to send a PR to fix windows support only to see that you already merged a PR that fixes it 😄

Anyway, it seems the version that is on npm doesn't include this fix. Would you be willing to publish an update?

Normally I'm a mac user but happen to be working on an electron.js project where we want to use this module to scan for local network devices on both mac/windows.

Thanks again for this great tool ❤️

natterstefan commented 5 years ago

Hi @HenrikJoreteg,

thanks for the feedback :) Happy to hear you like it. I just published a new version on npm. It includes the fix you mentioned.

Let us know if it works. Thank you!

HenrikJoreteg commented 5 years ago

Awesome, thanks! 👍