search

DylanPiercey / local-devices

🔮 Find devices connected to the current local network.
MIT License
139 stars 27 forks source link

fixed enobufs error #26

Closed harrypatrick442 closed 2 years ago

harrypatrick442 commented 4 years ago

i was getting this cos it tried to open too many sockets at once. To fix this i broke the task down so it opens only a smaller number of sockats at any one time

harrypatrick442 commented 4 years ago

I also implemented parseOne on windows.

natterstefan commented 3 years ago

Hi @harrypatrick442,

I am sorry for not responding to your PR. I must have missed that obviously. Before we take a closer look at the PR, can you please rebase it, fix the linter issues and take a look at how to add tests for this new feature in the test files?

This feature could be of value for many people using this in larger networks, that's why I'd like to properly add this.

Thanks for taking the time and the input. I appreciate that.