DylanPiercey / local-devices

🔮 Find devices connected to the current local network.
MIT License
139 stars 27 forks source link

replaced arp with ip on linux (arp is deprecated). 'arp -a' -> 'ip n'… #41

Closed lucafornerone closed 2 months ago

lucafornerone commented 3 years ago

replaced arp with ip on linux (arp is deprecated). searching for devices on linux is now faster.

natterstefan commented 3 years ago

Hi @lucafornerone, thanks for the PR. Looks like for some reason the checks do not run on this PR. Strange. Can you verify that the tests still pass, after this change, please?

lucafornerone commented 3 years ago

hi @natterstefan! yes, sorry. I'll make a commit when it's all right.

lucafornerone commented 3 years ago

It's ready. I had to adapt linux tests, 'arp' output is a little bit different from 'ip' output.

DylanPiercey commented 3 years ago

To be clear this would be a breaking change right?

lucafornerone commented 3 years ago

right.