DylanPiercey / local-devices

🔮 Find devices connected to the current local network.
MIT License
139 stars 27 forks source link

Raspberry Pi (linux) and partial win32 support, incl. jest test suite setup #7

Closed natterstefan closed 5 years ago

natterstefan commented 5 years ago

Related Issue

Added tools

Note: currently attached to my account in my forked repo.

Todos

Only, if you like the tools of course 😅.

natterstefan commented 5 years ago

@DylanPiercey The PR includes more than just the solution for #6. 😅

I was so focused and could not stop adding more and more features. I am very curious what you think about it. 😉

DylanPiercey commented 5 years ago

This looks excellent. Thanks for taking the time to go the extra mile on this one. It's going to take me a bit of time to properly review but I hope to get some time to this weekend.

natterstefan commented 5 years ago

Hi @DylanPiercey, thanks for the feedback. 💪 I'll take a look at it in more depth tomorrow.

natterstefan commented 5 years ago

Btw, you can check out my latest follow up commit @DylanPiercey: https://github.com/DylanPiercey/local-devices/pull/7/commits/628ddbab1968e71e2d5ba4594c71dcfffd0b67dd. Happy new year! 🎉

natterstefan commented 5 years ago

Hi @DylanPiercey, I just wanted to remind you to keep an eye on this PR. Would be great if we can further proceed. Right now, I need to do a workaround to still use your package on my Raspberry Pis. Thx.

DylanPiercey commented 5 years ago

Sorry for the delay, forgot about the status of this one. Just turned on travis and coveralls, going to merge this PR and then update the paths. Thanks again for your work on this!

DylanPiercey commented 5 years ago

Released as 2.0.0 😄

natterstefan commented 5 years ago

@DylanPiercey That's awesome! 🎉

There's just one more thing left. Looks like travis is case-sensitive. The links in the readme are broken, the same is true for coveralls.