DylanVanAssche / harbour-sailbook

Sailbook is an unofficial Facebook client for Sailfish OS
GNU General Public License v3.0
9 stars 9 forks source link

Automatically update Youtube-DL binary #55

Closed DylanVanAssche closed 6 years ago

DylanVanAssche commented 6 years ago

Youtube-DL binary can't be updated using the builtin updater because it lacks the Sailfish OS patch which is required to get it running.

The patch is very simple in the MakeFile: /usr/bin/env python -> /usr/bin/env python3 But isn't included in the official releases of Youtube-DL.

Solutions:

  1. Update Youtube-DL (before the build process) while compiling the RPM in release. This can be achieved in the .pro file using the following build macro: QMAKE_PRE_LINK

  2. Update Youtube-DL at runtime. When using the internal updater we need to apply the patch somewhere. Or if we use QNetworkAccessManager to download the source code (after pulling the version information) then we can apply the patch before running: make youtube-dl . Clean up is necessary afterwards.

  3. Any other suggestions?

DylanVanAssche commented 6 years ago

Own YT stream scraper implemented. won't fix