search

DylanVann / ant-design-draggable-modal

The Modal from Ant Design, draggable.
https://ant-design-draggable-modal.netlify.com
MIT License
165 stars 53 forks source link

Title not updated #5

Closed NoyChan closed 5 years ago

NoyChan commented 5 years ago

If you change the title prop, the modal didn't show the changed title unless you make a drag

DylanVann commented 5 years ago

Thanks for reporting!

It's due to sloppy usage of hooks. Fixed here - https://github.com/DylanVann/ant-design-draggable-modal/commit/fc5539f078e51f770b222fe22f5e717d6167708b

The fix is available in v0.0.13.

I've added ESLint with eslint-plugin-react-hooks to prevent any other issues like this:

Screen Shot 2019-03-19 at 1 00 37 PM