search

DylanVann / react-native-fast-image

🚩 FastImage, performant React Native image component.
MIT License
8.09k stars 1.47k forks source link

Fixed graphics context allocation issue #1007

Open aman32767 opened 9 months ago

aman32767 commented 9 months ago

Title: Resolved Graphics Context Allocation Issue

Description:

Proposed Changes This PR resolves an issue pertaining to graphics context allocation in the FFFastImageViewManager. The previous implementation utilized older graphics context handling methods, which could potentially lead to errors. This PR updates the code to leverage the newer UIGraphicsImageRenderer API, mitigating any context allocation problems.

Changes Made

Graphics Context Handling: It now employs UIGraphicsImageRenderer, a more modern API introduced in iOS 10. This API handles the creation, rendering, and cleanup of the image context automatically.

Renderer Usage: It now creates a UIGraphicsImageRenderer object (renderer) and employs it to execute the drawing operations.

Error Handling: It leverages a more modern API that is less susceptible to context allocation errors.

This PR addresses: #1006

AdamGerthel commented 9 months ago

Works well for me on iOS 17

MuhammadMuzammilQadri commented 9 months ago

Working fine on iOS 17. Thanks

johanholm commented 9 months ago

@DylanVann Please merge

fukemy commented 9 months ago

someone please tell me how to install this pull by npm

AdamGerthel commented 9 months ago

someone please tell me how to install this pull by npm

You can apply a patch, see https://github.com/DylanVann/react-native-fast-image/issues/1002#issuecomment-1742663000

mohitarora777 commented 8 months ago

@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?

AdamGerthel commented 8 months ago

@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?

I don't understand exactly what you mean by "I already have a patch applied for fast image in podsec file" - could you be a bit more specific? If you want to understand how to apply a patch for an npm package, the best way is to read the usage instructions for patch-package.

mohitarora777 commented 8 months ago

Got it thanx @AdamGerthel

Strate commented 7 months ago

Thank you for this!

hadnet commented 5 months ago

@DylanVann please, man, merge this.

Nazim-hasan commented 1 month ago

@DylanVann please, merge this.