DylanVann / react-native-fast-image

🚩 FastImage, performant React Native image component.
MIT License
8.09k stars 1.47k forks source link

Feat: update SDWebImage to latest ver #1034

Open Naturalclar opened 3 months ago

Naturalclar commented 3 months ago

resolves #1031

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (54376d8) to head (0b68b14). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1034 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 38 38 Branches 5 5 ========================================= Hits 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Vyazovoy commented 2 months ago

@DylanVann, could you please consider merging this PR with suggested changes and make a patch release? That would unblock a lot of people as we have to update SDWebImage to the latest version to make it comply with the Apple Privacy Manifest requirements (by May).

gsantiago commented 2 months ago

@DylanVann do you have plans to merge this PR? We also need the updated version of SDWebImage with the Apple Privacy Manifest

divvieesterhuizen commented 1 month ago

@DylanVann this PR seems like a great idea. Maybe merge it in ?