search

DylanVann / react-native-fast-image

🚩 FastImage, performant React Native image component.
MIT License
8.16k stars 1.5k forks source link

FastImage support for CameraRoll images is really needed. Instructions needed for enabling with SDWebImagePhotosPlugin #597

Open bobber205 opened 4 years ago

bobber205 commented 4 years ago

Describe the bug Spent the majority of my day trying to get FastImage to support a ph:/// that RN gives you a URI to when calling getPhotos() from the CameraRoll library.

There are a few open and closed issues saying this is fairly simply solved by adding the 'SDWebImagePhotosPlugin' plugin. That is much easier said than done. After hours of trying I've given up for now because I cannot get past the build error module 'SDWebImage' not found.

There may be more errors that occur after that but I wasn't able to see them. I understand the rationale for not including it in the main package, that's fine. But I think just telling people to install a new pod that simply doesn't work out of the box isn't acceptable either. I imagine a great deal of use cases for FastImage is displaying images from a CameraRoll.

To Reproduce Steps to reproduce the behavior if possible, or a link to a reproduction repo:

  1. Add pod 'SDWebImagePhotosPlugin'
  2. Run pod install
  3. Try to build and see the aforementioned error.

Expected behavior Should compile.

I've tried lots of combination of modifying the podfile's header search paths etc to no avail. I guess that's all I am really asking for is someone who nows more about the XCode build process to propose an update to the READMe about how to enable this plugin. The instructions for installation on the main SDWebImagePhotosPlugin repo don't account for (at least I think so) for adding it as a dependency for an existing dependency in a project. (RN Project -> Fast Image -> SDWebImage -> SDWebImagePhotosPlugin)

I really love this project and simply just wanna display CameraPhotos. Really appreciate the help!

priteshbaviskar commented 4 years ago

I'm facing the same issue. The instructions to install SDWebImagePhotosPlugin are either incomplete or vague.

dreampiggy commented 4 years ago

What cause this issue ? fast-image on iOS is actually backed by a native framework SDWebImage, and SDWebImagePhotosPlugin is a plugin to support loading camera roll photos.

Is this related to install ways ? Could you change both SDWebImage and SDWebImagePhotosPlugin into the CocoaPods, don’t mix them or using the vendored library.

bobber205 commented 4 years ago

It's been awhile since I worked on this but I remember like @priteshbaviskar said the instructions weren't easy to follow or aren't complete. Maybe they were written pre 0.60 and need to be updated? I don't have the expertise/time to debug what's going on. Someone who is more familiar with the plugins could probably figure it out easily. I hope anyway.