DylanVann / react-native-fast-image

🚩 FastImage, performant React Native image component.
MIT License
8.1k stars 1.48k forks source link

resizeMode behaviour is inconsistent between 8.5.12 and 8.6.0 #922

Closed Dimous closed 11 months ago

Dimous commented 1 year ago

Describe the bug Image resize behaviour is inconsistent between versions.

To Reproduce

<FastImage 
resizeMode={
FastImage.resizeMode.cover
}
source={
{
uri: "https://azbykamebeli.ru/upload/resize_cache/iblock/04d/748_900_1/04d58535526351ab165c5c11983f2791.jpg",
cache: FastImage.cacheControl.web,
priority: FastImage.priority.high
}
}
style={
{
width: "100%",
minHeight: 469.40028989251283
}
}
/>

Expected behavior Image resize behaviour to be consistent between versions.

Screenshots

v8.5.12

Screenshot_20220829-215717_azbykamebeli

v8.6.0

Screenshot_20220829-220403_azbykamebeli

Dependency versions


Changing FastImage.resizeMode.cover to FastImage.resizeMode.contain solves the problem, but the point is that the behavior shouldn't have changed between versions.

bhaltair commented 1 year ago

same problem

djMax commented 1 year ago

Is this just a case of the default value changing? (agree it shouldn't have)

djMax commented 1 year ago

(I ask that because if all we need to do is specify contain everywhere there was no value, that's an easy-ish thing to do. But if the change in behavior is more complex...)

jihokim2 commented 1 year ago

Same Problem. And AutoSizeExample is not working at 8.6.x in andorid.

forkball commented 1 year ago

Bump! This is happening in my project as well.

esthefanielanza-sothebys commented 1 year ago

I'm having the same issue on android devices

Dependency versions: "react-native": "0.67.5" "react": "17.0.2", "react-native-fast-image": "^8.3.4"

saif-o99 commented 11 months ago

anyone found a solution?

Dimous commented 11 months ago

This package is dead.

saif-o99 commented 11 months ago

Just converted to react-native-image-cache . seems alot better