Android RN 73 Support - Update build.gradle w/ Namespace

alexhernandez commented 11 months ago

alexhernandez commented 11 months ago

@DylanVann any MR feedback welcome

saif-o99 commented 11 months ago

Hey @alexhernandez, what could this fix? because the lib works fine for me without it with latest RN

alexhernandez commented 11 months ago

Hey @alexhernandez, what could this fix? because the lib works fine for me without it with latest RN

I updated MR title. It's an update for RN 73. See links in description

akimaleo commented 8 months ago

It's absolutely needed to be merged and released

felipecsl commented 7 months ago

you'll also need to remove the package attribute from AndroidManifest.xml

Himatheja commented 3 weeks ago

FAILURE: Build failed with an exception.

What went wrong: A problem occurred configuring project ':react-native-fast-image'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

DylanVann / react-native-fast-image