Closed emmamarichal closed 1 month ago
@emmamarichal
Thank you for this feedback! I will make these updates ASAP.
Sorry, i'm unfamiliar with Github, what do you mean by this: merge this PR before doing any modifications?
Thanks!
Hi @DylanYoungKoto,
You should have a button with "Merge this Pull Request". It will allow to merge my changes to your current repo, so your modifications can be added to the file I already updated.
So, to sum up:
Please let me know if it's ok :)
Thank you!
@emmamarichal Thank you! I have made those changes and re-uploaded the packaged glyphs file and exported the font. Thank you for your help!
@DylanYoungKoto Excellent! I'll take a look this week :) Thanks!
Hello @DylanYoungKoto!
I'm Emma, I work with the Google Fonts team, and I'm assigned to Faculty Glyphic project. My role here is to add some improvement to the font so it can follow the GF specs (https://googlefonts.github.io/gf-guide/index).
You will find the detail of my modifications in the commits, but please feel free to ask if you have any questions.
I also so have some suggestions for the design:
Some segments have colinear vectors and some outlines contain any semi-vertical or semi-horizontal lines:
I think the comma accent is a bit too small and light:
Please, merge this PR before doing any modifications, to avoid any conflicts :)
Cheers!