DylanYoungKoto / FacultyGlyphic

Faculty Glyphic is a typeface that pays homage to London's rich history and spirit of innovation, taking cues from carved typography, it combines modernity and heritage.
SIL Open Font License 1.1
9 stars 1 forks source link

Add Faculty Glyphic + some improvements #1

Closed emmamarichal closed 1 month ago

emmamarichal commented 1 month ago

Hello @DylanYoungKoto!

I'm Emma, I work with the Google Fonts team, and I'm assigned to Faculty Glyphic project. My role here is to add some improvement to the font so it can follow the GF specs (https://googlefonts.github.io/gf-guide/index).

You will find the detail of my modifications in the commits, but please feel free to ask if you have any questions.


I also so have some suggestions for the design:

Screenshot 2024-10-09 at 13 38 03

Please, merge this PR before doing any modifications, to avoid any conflicts :)

Cheers!

DylanYoungKoto commented 1 month ago

@emmamarichal

Thank you for this feedback! I will make these updates ASAP.

Sorry, i'm unfamiliar with Github, what do you mean by this: merge this PR before doing any modifications?

Thanks!

emmamarichal commented 1 month ago

Hi @DylanYoungKoto,

You should have a button with "Merge this Pull Request". It will allow to merge my changes to your current repo, so your modifications can be added to the file I already updated.

So, to sum up:

Please let me know if it's ok :)

Thank you!

DylanYoungKoto commented 1 month ago

@emmamarichal Thank you! I have made those changes and re-uploaded the packaged glyphs file and exported the font. Thank you for your help!

emmamarichal commented 1 month ago

@DylanYoungKoto Excellent! I'll take a look this week :) Thanks!