Dylanflini / buscaminas-typescript

1 stars 0 forks source link

feat: unit tests and validations added for expose cell use case #19

Closed danielglobant closed 2 years ago

danielglobant commented 2 years ago

Summary

The issue

Expose cell use case needs to be created

Diagnosis of the issue (bugs only)

Solution implemented

Considerations of the solution

References

Self review

Impact of these changes

This changes through Component impacts:

Evidences of expected changes

Add evidences here about each impact generated by your changes

Screen Shot 2022-09-20 at 10 18 46

Type of change

Squash and merge

We are following Angular commit messages guidelines

<type>(<scope>): <Jira-Issue subject>
<BLANK LINE>
<optional body>
<BLANK LINE>
<optional footer>

Types

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing or correcting existing tests
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation

Make sure you squash and merge your feature/bugfix branches into develop/release/hotfix branches using the suggested format.

Some examples.

feat: DP-1234 Edit assessment information
Frontend changes for editing an assessment:
- improve assign modal to receive an existing assessment
- integrate the reasign end point.
- couple of warnings removed
BREAKING CHANGE: the assign modal now receives 3 required parameters

More examples here