Dylanluo05 / DADY-Academy

2 stars 1 forks source link

Aryan Shah Individual ticket #35

Open Aryanboxout opened 1 year ago

Aryanboxout commented 1 year ago

Highlights

Total score averaged 17/20

Team Review Ticket

Scores Table

Items Self Somaditya Armaan Average
N@TM 5 5 5 5
Project quality, running cross domain and no crashes on FE to BE with these reviews 1 1 1 1
UI contains inputs that are validated for garbage, data cleaned (ie validate DOB or Password) 1 1 1 1
UI contains actions for Create, Read 1 1 1 1
UI contains actions for Update, Delete 1 1 1 1
JWT is guarding a feature, demonstration of cookies 0 0 0 0
Project quality, observation of comments in every function, class, or method reviewed. Be sure to review POJO, API 0 0 0 0
BE contains and API that shows that it handles error conditions (ie duplicate user id) 1 1 1 1
BE contains support for GET and POST methods 0 0 0 0
BE contains a database that supports Create, Read 1 1 1 1
BE contains a database that supports Update, Delete 1 1 1 1
Team review ticket 3 3 3 3
Individual review ticket 2 2 3 3

Duplicate id and UI input for login

Screen Shot 2023-03-02 at 9 16 45 AM

CRUD in BE

Screen Shot 2023-03-02 at 9 17 17 AM

UI contains input

Screen Shot 2023-03-02 at 9 17 57 AM

CRUD in UI

Screen Shot 2023-03-02 at 9 42 31 AM
somaditya1 commented 1 year ago

Scored a solid 17/20 with the use of binary grading. Work is present, structured and organized

xXAASXx commented 1 year ago

Total Score when Peer Reviewing: 17/20

Scored a solid 17/20 with the use of the 1 and 0 grading (Binary Grading) as everything looked swell and the ticked is nice and organized for everything that Mr. Mortensen is looking for.

Aryanboxout commented 1 year ago

Armaan Peer review- Total score: 19/20 Organized work with all necessary components except BE handling duplicate ID. However, overall project quality was well done and the concept was brilliant. The ticket was well organized and easy for the grader