Dyldog / luhman-obsidian-plugin

GNU General Public License v3.0
61 stars 18 forks source link

[BUG] On Create Sibling or Child Note, link to child or sibling incorrect #24

Closed jamesx4 closed 2 years ago

jamesx4 commented 2 years ago

When creating a child or sibling note with Add titles automatically enabled, the link on originating note only contains the Luhman ID, but no title. The new child or sibling note has the correct for the filename, but the link from originating page only has <id>. So when you click the link on the originating page it takes you to a new note, not the actual child note that was created. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Eforen"><img src="https://avatars.githubusercontent.com/u/725683?v=4" />Eforen</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I believe this is a duplicate of #17 and #6 and resolved by #9 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Eforen"><img src="https://avatars.githubusercontent.com/u/725683?v=4" />Eforen</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>For now I am closing this issue as it will be in the upcoming version see the roadmap issue for more information. ( #19 )</p> <p>If after we get this update out you still see the problem please feel free to reopen it.</p> <p>That said this exact issue is why I became one of the mantainers of this project so I will be confirming this is fixed in the upcoming release for sure.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Eforen"><img src="https://avatars.githubusercontent.com/u/725683?v=4" />Eforen</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Reopening this issue because its still not fixed just tested current codebase</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Eforen"><img src="https://avatars.githubusercontent.com/u/725683?v=4" />Eforen</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>This should be fixed in PR #31 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Eforen"><img src="https://avatars.githubusercontent.com/u/725683?v=4" />Eforen</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Resolved by #31 </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>