Dyldog / luhman-obsidian-plugin

GNU General Public License v3.0
60 stars 18 forks source link

[OTHER] Update Dependencies #26

Open brannonh opened 2 years ago

brannonh commented 2 years ago

We have some outdated dependencies and security vulnerabilities. We need to update and test to make sure nothing is broken.

Report from ncu as of 2022/09/09:

 @rollup/plugin-commonjs        ^18.0.0  →   ^22.0.2
 @rollup/plugin-node-resolve    ^11.2.1  →   ^14.0.1
 @rollup/plugin-typescript       ^8.2.1  →    ^8.5.0
 @types/json-schema              ^7.0.7  →   ^7.0.11
 @types/node                  ^14.14.37  →  ^18.7.16
 obsidian                       ^0.12.0  →   ^0.16.0
 prettier                        ^2.3.2  →    ^2.7.1
 rollup                         ^2.32.1  →   ^2.79.0
 rollup-plugin-import-css        ^2.0.1  →    ^3.0.3
 tslib                           ^2.2.0  →    ^2.4.0
 typescript                      ^4.2.4  →    ^4.8.3
Eforen commented 2 years ago

@brannonh @jvanz How critical do you think this is? do we need to do this before we push 1.1.1? I am just a little worried about everything exploading when we do...

Eforen commented 2 years ago

@jvanz and @brannonh what do you think of moving this tech dept to 1.2.0 so we can push out these bugfixes? This is the only remaining item in 1.1.1 we could also make a 1.1.2

For now I am going to move this to 1.1.2 so we can get 1.1.1 out the door.

I know there are security issue and stuff but it's not like those are not already present in the current version that's deployed.

brannonh commented 2 years ago

To me, this seems like at least a minor update (i.e., 1.2.0), since there is a high likelihood of breaking things. It's not really fixing bugs.

Eforen commented 2 years ago

do we want to move that and #37 into 1.2.0 and make a 1.3.0 for more features?

brannonh commented 2 years ago

I definitely agree with that. Let's keep 1.1.x focused on any future bug fixes, work on updating the code base in 1.2.x, and adding new features in 1.3.x.

Eforen commented 2 years ago

👍