search

Dyldog / luhman-obsidian-plugin

GNU General Public License v3.0
61 stars 18 forks source link

Fix insert link bug and add notifications on failures #9

Closed pauloday closed 2 years ago

pauloday commented 3 years ago

This fixes a bug where the add Zettel link command wouldn't work on my notes. I'm not sure why it was working on my test archive but not my actual one - it shouldn't have worked on either. Anyway it works on both now. I also added some notifications when things fail, so you don't get nothing happening silently when it can't get an id from the filename or something.

Fixes #17.

Eforen commented 2 years ago

@brannonh how would I go about pulling this down and fixing the conflict? Do I fork the repo or his repo or both or what?

I have not delt with pull requests in 2 repos I don't have permissions on before...

I see this as a kinda critical issue.

brannonh commented 2 years ago

@brannonh how would I go about pulling this down and fixing the conflict? Do I fork the repo or his repo or both or what?

I have not delt with pull requests in 2 repos I don't have permissions on before...

I see this as a kinda critical issue.

Honestly, I have never done that either. Let me see if I can resolve the conflicts real quick.

brannonh commented 2 years ago

@Eforen I was able to resolve the conflict. Looks like there is a missing this. in one line, but I can fix that right after the merge. I'll try to get this merged in the next couple of days.