DynaDojo / dynadojo

An Extensible Benchmarking Platform for Scalable Dynamical System Identification
https://dynadojo.github.io/dynadojo/
MIT License
14 stars 11 forks source link

demo/bug: Kuramoto AssertionError for certain timesteps #125

Open VictorHuynh opened 2 months ago

VictorHuynh commented 2 months ago

Describe the bug Calling make_data on KuramotoSystem for certain timesteps (e.g. 7, 14, 230) results in an AssertionError about data shape.

To Reproduce Steps to reproduce the behavior:

  1. Go to demos/systems/kuramoto_demo.ipynb
  2. In cell three, change timesteps to one of the problematic numbers listed above
    • or just iterate through timesteps until it crashes
  3. Run first three cells
  4. Should get AssertionError: data has shape (x, y+1, z), but it should be (x, y, z)

Expected behavior SystemChecker should not return an error, i.e. data shape should match up with the number of timesteps

Screenshots image

Desktop (please complete the following information):