demo/bug: lr_demo - Githubissues

DynaDojo / dynadojo

An Extensible Benchmarking Platform for Scalable Dynamical System Identification

https://dynadojo.github.io/dynadojo/

MIT License

11 stars 9 forks source link

demo/bug: lr_demo #59

Open sameerashahh opened 1 month ago

sameerashahh commented 1 month ago

Describe the bug ImportError: cannot import name 'plot_old' from 'dynadojo.utils.kuramoto'

To Reproduce Steps to reproduce the behavior:

Go to demos/algorithms/lr_demo.ipynb
Run each cell
Error occurs in the second sell.

Expected behavior A correct plot function should be imported from src/dynadojo/utils/kuramoto.py

lmclane04 commented 2 weeks ago

Delete plot_old. Program only uses plot() so we only need to import plot from dynadojo.utils.kuramoto. After this, the following errors also occur in a few places.

plot() got an unexpected keyword argument 'legend_labels'
resolve by changing 'legend_labels' to 'labels'
plot() got multiple values for argument 'max_oscillators'
resolve by deleting "timesteps", which is not a parameter in plot().