search

DynamicDestiny123 / E_Wicks_Assessment_1

Repository for Object Oriented Programming assessment 1.
0 stars 0 forks source link

Code Review - Lauren Davies #1

Open LDavies18 opened 1 year ago

LDavies18 commented 1 year ago

Throughout the code, comments are meaningfully placed and well used. Pack, Class and Program classes are all well set out making them easy to understand, while Testing class is crowded but not unreadable. The Card class would benefit from the implementation of encapsulation, as this would reduce the risk of errors due to changes in data. Error handling is established well, within both the Pack and Testing classes. When running the code everything executes perfectly. Although including a visual representation of the cards my benefit the tester as it would make it easier for them to understand what has occurred.

Overall the Program is written well and executes exactly as it should. :)

DynamicDestiny123 commented 1 year ago

Thanks! I'll look into how I can change the Card class to add encapsulation and how I can make the Testing class have a better visual representation of what's going on. I'll also add some spacing to the comments and code in Testing to make it more readable?