DynamicTreesTeam / DynamicTrees-PHC2

Compatibility Mod between Dynamic trees and Pam's HarvestCraft 2: Trees
MIT License
0 stars 4 forks source link

Port for 1.19.2 #5

Closed Al3xCalibur closed 1 year ago

Al3xCalibur commented 1 year ago

Context

It is not intended to be merged like that because a new branch should be created AND there are still issues.

First, the goal was to go as direct as possible to the migration.

What is working per my test?

What is NOT working?

Code issues

The main element that I didn't find a good solution is for the feature canceller, I can get the same Feature from the PMHC2-Tree mod. So I decided to loop over all of them and use the ResourceLocation. I'm not sure it works as intended. Related commit: https://github.com/DynamicTreesTeam/DynamicTrees-PHC2/commit/1481c5c34f390801835c7617c3b8d506db20fdd6