search

DynamicTreesTeam / DynamicTrees

Minecraft Forge mod providing dynamic trees that progressively grow from seed to maturity.
MIT License
240 stars 98 forks source link

Assistance with tree placement/appearance #405

Closed Gaelmare closed 4 years ago

Gaelmare commented 4 years ago

I'm the developer of a TFC/Dynamic Trees addon. https://www.curseforge.com/minecraft/mc-mods/dynamictreestfc

I'm struggling with trunk textures. In the attached screenshot, the falling tree model has the side texture where the rings should be. The ends of tree branches also have the side textures everywhere.

2020-02-15_01 35 29 2020-02-15_01 34 50

Any suggestions? Code at https://github.com/Gaelmare/dynamictreestfc

Thanks!

Dynamic Trees 0.9.7 TFC 0.29.0.115 Forge 1.12.2-14.23.5.2847 MCP stable_39

Gaelmare commented 4 years ago

Also wouldn't mind some advice on how to avoid trees looking like this: 2020-02-15_19 56 53 2020-02-15_22 52 34

ferreusveritas commented 4 years ago

Not exactly sure what's going on with the texture issue just yet. But the reason why the worldgen is producing those frankentrees is that the coded tree models you're using for spawn don't have the proper block boundary radius. Make sure the JoCodes in the trees assets files have the right integer radius to fully contain the model.

Edit: Nevermind, I see that you simply copied the trees JoCodes from the main mod, which should work fine for you.

ferreusveritas commented 4 years ago

Are you actually using the provided Poisson Disc algorithm for placement? If not you're going to have trouble. The trees will likely often look that way if they aren't perfectly radially spaced. Feel free to copy the Poisson Disc algorithm and modify it to suit your needs.

Gaelmare commented 4 years ago

Thanks for the advice. I'm not using the poission disc location algorithm. The tree radius selection is my current challenge. TFC worldgen code selects a tree species and tests individual locations with the treegen code. There is a Flora density number which I've attempted to relate to library radius choice, but I'm not super happy with.

Do you have a world save with your JoCode library save structures and MCF blocks built in 1.12? JoCodes from the existing libraries don't seem to match some of the TFC species well. The only one root per branch network is the immediate cause of the broken tree renders, etc. but I get why that restriction exists. The interesting thing is that the isThick trees seem to have the right end textures on the trunks, but the regular trees do not.

ferreusveritas commented 4 years ago

Closing that as the issue is old and you're in the discord channel anyway so we can just work it out.