DynamicTreesTeam / DynamicTrees

Minecraft Forge mod providing dynamic trees that progressively grow from seed to maturity.
MIT License
235 stars 98 forks source link

[BUG] dynamictrees:dendro_potion recipe turns any item in the game into a DT potion #819

Closed Nycto97 closed 7 months ago

Nycto97 commented 11 months ago

Describe the bug The brewing recipe for dynamictrees:dendro_potion accepts all items/blocks from the game as input, effectively meaning you can brew this potion with any item/block registered to the game, both vanilla and modded.

Also, JEI showing wrong information about what the recipe will actually accept.

MineColonies is not really related, but I keep it listed because in their Alchemist tab, you can see all the pages.

To Reproduce Steps to reproduce the behavior: (UPDATED)

  1. Open brewing stand GUI
  2. Insert Blaze Powder, charcoal on the top and literally any item/block at the bottom
  3. Get the Biochar Base Potion (dynamictrees:dendro_potion) in return

(OLD) 1. Have (MineColonies + required dependencies +) Dynamic Trees + JEI installed 2. Launch client 3. Join a world (singleplayer or multiplayer) 4. Open JEI GUI 5. Right-click (or hover and 'U') any item 6. Go to Alchemist tab 7. Left-click the dynamictrees:dendro_potion 8. Go to Alchemist tab 9. See all the pages with recipes

Screenshots image

Input: image

Output image

Rendering Glitches Not related, running game only with mods listed below

Additional information

Mods List image

Forge version 1.19.2-43.3.2

github-actions[bot] commented 8 months ago

This issue has gone stale due to inactivity. Please comment again if it is still an issue.

EagleEyeLogic commented 3 months ago

This is no BUG in general. There is simply no logic behind or in the brewing system of DynamicTrees since 1.16.5

I've patched some logic in but need more infos about the potion use.

BIOCHAR only the base potion for all other DEPLETION, GIGAS, BURGEONING, FERTILITY, PERSISTENCE, HARVEST and DENUDING based on BIOCHAR and no dynamic use now or planed TRANSFORM based on BIOCHAR and the only potion used dynamic including addons??