Missing slash in generated url for actions

DynamicsNinja / InAppNotificationBuilder

MIT License

11 stars 2 forks source link

Missing slash in generated url for actions #4

Closed MscrmTools closed 2 years ago

MscrmTools commented 2 years ago

The code generated for Power Automate has an issue when building the url for the action to perform. There is a missing Slash

Deployment: Online
DB Version: 9.2.22033.152
Connection Controls Version: 1.2022.4.48
XrmToolBox Version: 1.2022.2.54
Tool Version: 1.2021.12.1

DynamicsNinja commented 2 years ago

I tried to reproduce it on a few organizations but didn't have the issue above. It's probably related to ConnectionDetail.WebApplicationUrl that I'm using for the base URL (which has / in the end in my case).

Is it maybe better to put ConnectionDetail.OriginalUrl instead and add / at the end since it is the same but without the ending slash?

MscrmTools commented 2 years ago

I guess the best is to test if the url ends with a slash and add it if it is missing

DynamicsNinja commented 2 years ago

Good point, I'll make it that way.