DynamicsValue / fake-xrm-easy

FakeXrmEasy: The Test Automation Framework for the Power Platform / Dataverse
https://dynamicsvalue.github.io/fake-xrm-easy-docs/why/
Other
25 stars 12 forks source link

Review read access permissions for GitHub Packages restore in pull request workflows #97

Open jordimontana82 opened 1 year ago

jordimontana82 commented 1 year ago

External collaborators are not able to restore packages due to not having package restore permissions despite repos and packages being public.

Also update deprecated CLA action.

Also review Sonar login token.

BetimBeja commented 1 year ago

@jordimontana82 there is another issue/deprecation warning with the CLAAssistant Action ex. https://github.com/DynamicsValue/fake-xrm-easy-core/actions/runs/4871971849

image

I noticed that your repo is some commits behind 😉

jordimontana82 commented 1 year ago

Thanks for the heads up @BetimBeja !

jordimontana82 commented 1 year ago

@BetimBeja, when you have a chance, can you try submitting a PR against 2x branch in abstractions repo to test, please?

jordimontana82 commented 1 year ago

Some progress there, now Sonar quality gate token outstanding...

jordimontana82 commented 1 year ago

@BetimBeja Updated some permissions, but no luck still, we'll see ...

https://community.sonarsource.com/t/sonar-token-permissions-in-pull-request-github-actions/90614/7?u=jordim