search

DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

Import multiple dlls where first part of qulified name is the same causes dynamo to crash #11656

Open SHKnudsen opened 3 years ago

SHKnudsen commented 3 years ago

Dynamo version

Dynamo: 2.12.0.4852 But this has been an issue for at least a few versions back.

Operating system

OS: Microsoft Windows NT 6.2.9200.0

What did you do?

Load two dlls where the start of the FullName is the same, using the + icon in the library browser, in the same Dynamo session.

i.e. First load someName.anotherName.differentName then load someName.anotherName.newName. First load is fine, but second one causes dynamo to crash. Think i tracked the issue down to here https://github.com/DynamoDS/Dynamo/blob/master/src/LibraryViewExtension/LibraryViewCustomization.cs#L100. But not sure i understand the logic of this check.

The weird thing is that if i load someName.anotherName.differentName close dynamo, reopen and then load someName.anotherName.newName there is no issue.

What did you expect to see?

My dll loaded

What did you see instead?

dynamo crash

github-actions[bot] commented 3 years ago

Thank you for submitting the issue to us. We are sorry to see you get stuck with your workflow. While waiting for our team member to respond, please feel free to browse our forum at https://forum.dynamobim.com/ for more Dynamo related information.

mjkkirschner commented 3 years ago

@SHKnudsen you say "load two dlls where the start of the full name is the same" - do you literally mean the names of the dlls or do you mean the names of types in those dlls?

SHKnudsen commented 3 years ago

The name of the .dll.

Cant say if they type names has something to do with it as well, but I don't think so, it seems like it never gets to the type loading before the crash.

There are no issues if I load two .dlls right after each other where the first part of the name does not match.