Fix failing test that checks for runtime loaded assembly when running in serial

aparajit-pratap commented 2 weeks ago

Purpose

attempt fixing test for linux

Declarations

Check these if you believe they are true

[ ] The codebase is in a better state after this PR
[ ] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] All tests pass using the self-service CI.
[ ] Snapshot of UI changes, if any.
[ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
[ ] This PR modifies some build requirements and the readme is updated
[ ] This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

mjkkirschner commented 2 weeks ago

also curious, where are the tests actually running on linux?

github-actions[bot] commented 2 weeks ago

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

aparajit-pratap commented 1 week ago

also curious, where are the tests actually running on linux?

They are running on DynamoWinBuild here.

mjkkirschner commented 1 week ago

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

aparajit-pratap commented 1 week ago

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

Is there anything special we do for FFITarget?

mjkkirschner commented 1 week ago

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

Is there anything special we do for FFITarget?

I think we actually inadvertently distribute FFITarget today - but for other test binaries we exclude them for the dynamocore builds on master-15 here: https://github.com/DynamoDS/Dynamo/blob/f4210a1191c246270634cf28dd3a014baff7bef5/src/DynamoInstall/DynamoInstall.wixproj#L77

For the nugets I think we exclude in the nuspecs.

aparajit-pratap commented 1 week ago

@mjkkirschner I'll make a separate PR to exclude test related assemblies from the nuspec definition for the serviceruntimecore package.

DynamoDS / Dynamo