DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

DYN-7821:changed compatibility calculation algorithm #15644

Closed dnenov closed 1 week ago

dnenov commented 1 week ago

Purpose

Change to how package version Compatibility is calculated. The main changes are that:

Declarations

Check these if you believe they are true

Release Notes

Reviewers

@achintyabhat @reddyashish @zeusongit @QilongTang

FYIs

@saintentropy

github-actions[bot] commented 1 week ago

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

reddyashish commented 1 week ago

Passed: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16801/

mjkkirschner commented 1 week ago

There actually is a static logger: https://github.com/DynamoDS/Dynamo/blob/master/src/NodeServices/MessageEvents.cs#L71

reddyashish commented 1 week ago

Thanks Mike, I will make this change.

reddyashish commented 1 week ago

addressed it here https://github.com/DynamoDS/Dynamo/pull/15653