search

DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.72k stars 632 forks source link

Element Binding/Dynamo not properly deleting elements after closing and Re-Opening Revit "Project File" and Re-running DYN File #5224

Closed RonFS closed 8 years ago

RonFS commented 9 years ago

I have been trying to troubleshoot this issue, and have narrowed it down to one specific situation. Any help/insight into this would be greatly appreciated.

Let's say I have, for example, opened a new Revit Project File and I have a DYN file that is reading point data from excel and breaking this data up to apply to an AdaptivePoints Component. If I:

1) Run the Script -Element ID's are generated 2) Save the Excel File (this will make Dynamo re-compute the script when I hit Run) and run the script -Element ID's remain the same 3) "Save As" Excel file with a new name and run the script -Element ID's remain the same 4)Use different excel file with point data (just a previous design version, so the point data is different) and run the script -Element ID's remain the same 5)Save the Revit Project File and Dyn File, close and re-open the files, and run the script -Element ID's have changed -New Adaptive Components have been generated on top of the old ones and the old ones are remain

The problem occurs when this Revit Project File, a model containing only the facade of a building, is linked back into the central model. Now that these facade elements have new element ID's, all annotation (DIMS, keynotes, etc.,) are blown away. As you can imagine this becomes a problem during the documentation process. Is this a unique issue or something that is currently being worked? I found this conversation that discusses a similar issue, (https://github.com/DynamoDS/DynamoRevit/pull/301) but sounds as the issue has been fixed. Running Revit 2015 and Dynamo 0.8.2.2392.

RonFS commented 9 years ago

I tried the same procedure on a very simple script, and it resulted in the same thing. When saving, closing and re-opening the component was not replaced. It was instantiated on the old one and the element ID was changed. element id not binding

riteshchandawar commented 9 years ago

This seems to be a valid issue, Which version of Dynamo you are using currently?

If you are using 0.8.2 then Can you please try this workflow on 0.8.1 if possible?

Meanwhile I will investigate it at my end as well.

Thanks, Ritesh

riteshchandawar commented 9 years ago

Hello @RonFS

I tried your scenario at my end using our own Adaptive Component Sample. (Help>Samples>Revit>Revit_Adaptive Component Placement) I am able to reproduce this on 0.8.1 and 0.8.2 but on 0.8.3 it is not reproducible.

I tried below steps.

I tried above scenario multiple times with differnet number of AC and it was updating correctly.

Is it possible for you to try this out on daily build? (http://dynamobuilds.com/)

Let me know your findings.

Thanks, Ritesh

RonFS commented 9 years ago

Hello @riteshchandawar,

Thank you for helping me to resolve this issue.

When running my test script described above I was using 0.8.2. I then updated to 0.8.3.503 and obtained the same results. I also took your recommendation to update to the latest daily build and also obtained the same results.

It took me a while to run the example file in the procedure you described, as every time I installed the latest daily build it would delete the sample files. I ended up copying the sample files on to my desktop and copying them back into my program files after installing the latest build.

After following your procedure with the sample files I still ended up with duplicate AdaptiveComps.

You seemed to have a methodical process for creating the association between RVT and DYN files. Is this necessary for maintaining the history of elements or you are simply outlining a potential situation? Does dynamo not maintain this history within the DYN file?

Also, as a side note, when running my test script I was not able to see the Points I was generating in Dynamo in the Dynamo view port. I was only able to see them in Revit. I checked my view settings in Dynamo and they were correct. Do I have a bigger issue here?

Please let me know your thoughts.

Many Thanks,

Ron

RonFS commented 9 years ago

@riteshchandawar

I am also willing to hold a quick goto meeting so we can be sure there is no miscommunication on the issue. It surprises me that you were able to not reproduce this issue in 0.8.3, yet I was.

riteshchandawar commented 9 years ago

Sure, let me know when you want to donit?

RonFS commented 9 years ago

Anytime before noon works for me (our Revit consultant would like to sit in as well and that is his schedule). However if that doesn't work, I can meet with you at any time that works for you. My biggest priority is getting this resolved.

Let me know what time you would like to meet and I will copy and paste the Zoom meeting info here.

riteshchandawar commented 9 years ago

For me afternoons are prefarable. Can we do it tomorrow afternoon 3.00 Pm my time. (Singapore Time.)

Thanks, Ritesh

RonFS commented 9 years ago

Ritesh,

I didn't think about the fact that you could actually be anywhere when I asked what time is convenient for you. I am in MST. 3pm Singapore time would be 1am my time. Can we try for 7-8am my time, or, 7-8am your time? I'm open to other suggestions, however, your afternoon is my early morning.

http://www.timebie.com/timezone/mountainsingapore.php Thanks,

Ron

RonFS commented 8 years ago

Hi @riteshchandawar ,

Sorry I have been busy lately. Has anything else come of our previous conversations? Would you still be willing to set up a quick conference call?

Thanks,

Ron

riteshchandawar commented 8 years ago

You can set up somthing for this Thursday or Friday 7-8 Am my time.

Thanks, Ritesh

RonFS commented 8 years ago

Sounds good. I will send a meeting invite for 7:30 AM your time.

Thanks,

Ron

kronz commented 8 years ago

@RonFS can you check this? We did a lot of work on Adaptive Components in 0.9.1, this should be fixed

RonFS commented 8 years ago

Hi @kronz ,

We eventually found out this was an isolated issue. After trying on a different machine, the binding worked fine. I think this may have something to do with the fact that I was doing "clean" installs whenever I updated my dynamo. I think that in that process things got a little screwy (maybe certain things still existed in my registry which I did not look into).

Since then, I simply download the latest releases and install them without removing previous dynamo information from my system, and have not had a problem since.

However, the cause of that glitch was never really determined.

Cheers,

Ron

ikeough commented 8 years ago

We're closing this issue as it cannot be reproduced on more recent builds of Dynamo. Please re-open if you're still experiencing this problem, or have an example which reproduces the problem.