search

DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

R15 branch of "TransactionManager" and "RevitSchedulerThread" lagging behind. R16 branch regressed #5783

Closed dimven closed 8 years ago

dimven commented 8 years ago

First of all the 2015 branch is not up to date: https://github.com/DynamoDS/DynamoRevit/commit/1aa3d60b5985cdc40ee9f7999f223d1709cf1dd2

But the more worrying thing is that the update might have caused a regression. I have no problem executing my code in Revit 2015 (or 2014 with 0.82), but in Revit 2016 the transaction manager seems to be unable to open multiple transactions:

Revit 2015: 2015-12-02_15-38-24

Revit 2016: 2015-12-02_15-40-13

Any idea what might be causing this? I don't believe that anything major has been changed in the 2016 API that can cause this failure.

Edit: it seems that the thread engine is behind in R15 as well. Could this be causing the observed regression in R16? https://github.com/DynamoDS/DynamoRevit/blob/Revit2016/src/Libraries/RevitServices/Threading/RevitSchedulerThread.cs#L40-L44

dimven commented 8 years ago

I've solved the issue by force closing the transaction instance at the start of the function. Still not sure why this is required only in Revit 2016. I'd still be interested in finding out why the two branches are different and if that was causing the issue in the first place.

I guess this is solved but I'd like to leave it open for some feedback from the dev team.