search

DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.72k stars 633 forks source link

Element.Geometry inconsistency #6394

Closed rbosborne closed 8 years ago

rbosborne commented 8 years ago

Using 0.9.2. I have lately noticed many elements that are not working with Element.Geometry. Attached is a file containing 3 elements. Only one of the 3 (the rectangular beam) will work with element.geometry in Dynamo. If the rectangular beam is connected and joined to the elliptical column, it will not work with element.geometry.

I have looked at all 3 elements using RevitLookup. For the Rectangular beam, the geometry only shows "Solid". For the Ellipse Column it shows "GeometryInstance" and "Solid". For the cable loop it only shows "GeometryInstance".

I am wondering

  1. Why won't all 3 elements work with Element.Geometry (can the node perhaps be fixed to work for all 3?)
  2. if there is some issue on the way the families are built to make it work with Element.Geometry - should that be documented so that people know best practices to make their elements work with Dynamo?
  3. Is there an issue with nested (non-shared) families working with Element.Geometry? (A Generic Model nested into an empty Structural Framing family perhaps??)

Element Geometry fails.zip

kronz commented 8 years ago

thanks @rbosborne , looks like this has been the behavior at least since 0.8.2,

@aparajit-pratap It looks like Dynamo doesn't like to deal with 2 different situations. One is elliptical extrusions and I think the other issue is conical elements, or maybe a sweep to a point?

rbosborne commented 8 years ago

A bit more testing on my end. I agree that it appears that the ellipse and the swept conical blend are the problem pieces in this case. I deleted the swept conical blend out of the family and reloaded it. See image for result - Element.Geometry did successfully generate something - just not the correct thing. elementgeometry

For some background - these are not the only failures I having. What I was attempting to do was to take the entire rigging assembly seen below and "bake" it into a DirectShape family (easier to move one thing around the project than 20 things...). The turnbuckles and shackles also have messy geometry in them that Element.Geometry does not like... rigging pic

mjkkirschner commented 8 years ago

KroNz did you try this on 1.x after We made changes to the cone face converter ?

Sent from my iPhone

On Apr 8, 2016, at 6:47 AM, rbosborne notifications@github.com wrote:

A bit more testing on my end. I agree that it appears that the ellipse and the swept conical blend are the problem pieces in this case. I deleted the swept conical blend out of the family and reloaded it. See image for result - Element.Geometry did successfully generate something - just not the correct thing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

dimven commented 8 years ago

@rbosborne

It looks like you are using nested revolved edges (sweeps). There was an earlier issue with them described here: https://github.com/DynamoDS/Dynamo/issues/3679

I don't believe that was ever resolved. This is on 0.92 stable:

2016-04-11_10-51-39

Seems to be a bit better in the 1.0 dailies. Curved faces are still a big challenge: 2016-04-11_11-04-38

2016-04-11_11-09-26

So one way to circumvent this, is to make the curved face inside your family faceted.

ikeough commented 8 years ago

@dimven Thanks for the tips and the issue link. @rbosborne I'm closing this issue as the one that @dimven linked covers it. @mjkkirschner can you please confirm this is the same issue?