DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

Issue with the Override element color node/def #880

Closed jbenoit44 closed 9 years ago

jbenoit44 commented 10 years ago

Hi guys, here's what happens in the console with Revit 2013, trying to play with the sample def provided:

All Tests Passed. Core library loaded OK. Welcome to Dynamo! 00:00:01.6778563 elapsed for loading Dynamo main window. Opening home workspace C:\Autodesk\Dynamo\Core\samples\22 Color\OverrideGraphicsInView_Walls.dyn... Clearing workflow... 00:00:00.0008871 elapsed for loading xml.

Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf59" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5a" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5b" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5c" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5d" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5e" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5f" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf60" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf61" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf62" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf63" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf64" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf65" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf66" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf67" not found in Document.

00:00:00.2697098 ellapsed for loading nodes. 00:00:00.0186649 ellapsed for loading connectors. 00:00:00.0029692 ellapsed for loading notes. Applying model migration from 0.5.3.x to 0.6.0.x 00:00:01.1513572 ellapsed for loading workspace. System.TypeLoadException: Could not load type 'Autodesk.Revit.DB.OverrideGraphicSettings' from assembly 'RevitAPI, Version=2013.0.0.0, Culture=neutral, PublicKeyToken=null'. at Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) at Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) at Dynamo.Models.NodeModel.__eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) at Dynamo.Revit.RevitTransactionNode.__eval_internal(FSharpList1 args, Dictionary2 outPuts) at Dynamo.Models.NodeModel.<>c__DisplayClass44.<evaluateNode>b__41() Could not load type 'Autodesk.Revit.DB.OverrideGraphicSettings' from assembly 'RevitAPI, Version=2013.0.0.0, Culture=neutral, PublicKeyToken=null'. at Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) at Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) at Dynamo.Models.NodeModel.eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) at Dynamo.Revit.RevitTransactionNode.eval_internal(FSharpList1 args, Dictionary2 outPuts) at Dynamo.Models.NodeModel.<>cDisplayClass44.b41() Evaluation completed in 00:00:00.4524185

and I also have an issue with the node in Revit 2014:

All Tests Passed. Core library loaded OK. Welcome to Dynamo! 00:00:01.1010201 elapsed for loading Dynamo main window. Opening home workspace C:\Autodesk\Dynamo\Core\samples\22 Color\OverrideGraphicsInView_Walls.dyn... Clearing workflow... 00:00:00.0004468 elapsed for loading xml.

Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf59" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5a" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5b" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5c" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5d" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5e" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf5f" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf60" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf61" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf62" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf63" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf64" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf65" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf66" not found in Document. Element with UID "5091baf4-c802-459a-8a18-a30b661c48ef-0002cf67" not found in Document.

00:00:00.2218889 ellapsed for loading nodes. 00:00:00.0170719 ellapsed for loading connectors. 00:00:00.0030528 ellapsed for loading notes. Applying model migration from 0.5.3.x to 0.6.0.x 00:00:00.9845570 ellapsed for loading workspace. System.InvalidOperationException: La séquence ne contient aucun élément correspondant. à System.Linq.Enumerable.First[TSource](IEnumerable1 source, Func2 predicate) à Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) à Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.__eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) à Dynamo.Revit.RevitTransactionNode.__eval_internal(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.<>c__DisplayClass44.<evaluateNode>b__41() La séquence ne contient aucun élément correspondant. à System.Linq.Enumerable.First[TSource](IEnumerable1 source, Func2 predicate) à Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) à Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) à Dynamo.Revit.RevitTransactionNode.eval_internal(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.<>cDisplayClass44.b41() Evaluation completed in 00:00:00.3433672 Active view is now travail 3D

Hope it helps.

LevL commented 10 years ago

This sample is for Revit r2014. r2013 does not have OverrideGraphicSettings class, hence exception.

jbenoit44 commented 10 years ago

ok, don't work for me in 2014 too, both samples for walls or families. I hope it's not a localized version issue...French here.

LevL commented 10 years ago

What happens on r2014? OverrideGraphicSettings should be defined and should not throw exception.

jbenoit44 commented 10 years ago

image and the console says:

System.InvalidOperationException: La séquence ne contient aucun élément correspondant. à System.Linq.Enumerable.First[TSource](IEnumerable1 source, Func2 predicate) à Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) à Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.__eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) à Dynamo.Revit.RevitTransactionNode.__eval_internal(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.<>c__DisplayClass44.<evaluateNode>b__41() La séquence ne contient aucun élément correspondant. à System.Linq.Enumerable.First[TSource](IEnumerable1 source, Func2 predicate) à Dynamo.Nodes.OverrideColorInView.Evaluate(FSharpList1 args) à Dynamo.Revit.RevitTransactionNodeWithOneOutput.Evaluate(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.eval_internal_recursive(FSharpList1 args, Dictionary2 outPuts, Int32 level) à Dynamo.Revit.RevitTransactionNode.eval_internal(FSharpList1 args, Dictionary2 outPuts) à Dynamo.Models.NodeModel.<>cDisplayClass44.b41() Evaluation completed in 00:00:00.1422526

LevL commented 10 years ago

I wonder if this is caused by lack of FillPatternElement with name "Solid fill" (see node implementation, file DynamoRevit\Nodes\View.cs, line 806: solidFill = patternCollector.ToElements().Cast().First(x => x.GetFillPattern().Name == "Solid fill"); ) It might be that you are right: your element name gets translated and match fails.Could you try to add such element with English name and retest? (Or change the name on this line to the name of your element and rebuild dynamo.) Thanks!

jbenoit44 commented 10 years ago

Solid fill is hardcoded. it cannot be renamed. I added a pattern with this name, but Revit is smarter than that! I would "love" to be able to rebuild Dynamo......but I don't think my programming skill is high enough! The name of the solid filled pattern in French is "Uni". is there a way to use Solid fill in Dynamo without using the litteral name, so that localized version work?

kronz commented 10 years ago

Arg! Localization strikes again!

jbenoit44 commented 10 years ago

Hi guys. any chance this get a fix in the coming release?

For the record and to help localized people: take this file to make your stuff in the meantime. https://github.com/ikeough/Dynamo/blob/master/test/revit/View/OverrideElementColorInView.rvt (right click on Raw, save link as)

jbenoit44 commented 10 years ago

any news on this? I'm stuck with this. I tried to do it with Python node, but as I manage to define projection fill pattern, I can't deal with colors. any help would be welcomed.

kronz commented 10 years ago

Hey Julien, can you see if this is still happening to you in the daily builds?

Thanks Z

jbenoit44 commented 10 years ago

image result in the latest build available, French template. image with an English template.

jbenoit44 commented 10 years ago

still not resolved in todays build. image

monikaprabhu commented 9 years ago

@jbenoit44 is this still an issue ? i could not acces the file -file not found here. https://github.com/ikeough/Dynamo/blob/master/test/revit/View/OverrideElementColorInView.rvt -

jbenoit44 commented 9 years ago

still an issue in French revit version. I tried the sample definition provided with dynamo.

RodRecker commented 9 years ago

@jnealb We are doing localization work now. We should be able to resolve this. Let's get a defect logged.

jbenoit44 commented 9 years ago

Thanks. Got custom node for now but not as fast as builtin.

jnealb commented 9 years ago

@jbenoit44 Hi Julien, a couple of questions:

  1. What version of French Revit are you using? 2014 or 2015?
  2. Are you running French Windows 7? If not, exactly what version?

We are investigating, thanks, Neal

jbenoit44 commented 9 years ago

I use both 2014 and 2015. My dev platform for new stuff in dynamo is 2015. My OS is Windows 7, French. It is only related to the name of the FillPattern: "Solid" in English, "Uni" in French. I know some guys from Germany that have the same issue. It runs well when using Revit API in python nodes.

jnealb commented 9 years ago

@jbenoit44 2 questions:

  1. Are the Revit versions French builds or US builds of the products?
  2. Can you post or send us your code, dyns etc? The links above are no longer valid. The issue with the Element.OverrideColorInView node error is being tracked with MAGN-5681.
jbenoit44 commented 9 years ago

Revit are French builds. I will post a link to download file and dyn.

Julien BENOIT

Le 16 déc. 2014 à 18:05, Neal Burnham notifications@github.com a écrit :

@jbenoit44 2 questions:

  1. Are the Revit versions French builds or US builds of the products?
  2. Can you post or send us your code, dyns etc? The links above are no longer valid. The issue with the Element.OverrideColorInView node error is being tracked with MAGN-5681.

— Reply to this email directly or view it on GitHub.

jnealb commented 9 years ago

@jbenoit44 @RodRecker @kronz @LevL Hi Julien, with updated French Windows 7 localized to France and the French build of Revit 2015 the RevitColor sample under Help does not give an error with the Element.OverrideColorInView node using either Dynamo 7.5 RC or the current 7.6 build. revit_version is our Revit version information. We would like to understand the deltas between your configuration and ours, can you send us your Revit version information? Merci, Neal

jbenoit44 commented 9 years ago

It doesn't work for me with build 0.7.5.3437. my information about Revit: image The sample file provided is based on a US template, therefore it has the Solid fill pattern inside. image give a try with the template provided with FR build, Construction-DefaultFRAFRA.rte. Solid fill is named "Uni". image

jnealb commented 9 years ago

@jbenoit44 We can reproduce the issue and are working towards a fix. Merci beaucoup pour tous ces renseignements, Julien.

kronz commented 9 years ago

duplicate issue with http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-940 We have to squash this one . . . wicked old

jnealb commented 9 years ago

@jbenoit44 @LevL We think this is fixed with 0.7.6.3850 which can be downloaded from Dynamobuilds.

jbenoit44 commented 9 years ago

I will check this asap. If so, I think I will have a celebrating dance :)!

Julien BENOIT

Le 21 janv. 2015 à 20:07, Neal Burnham notifications@github.com a écrit :

@jbenoit44 @LevL We think this is fixed with 0.7.6.3850 which can be downloaded from Dynamobuilds.

— Reply to this email directly or view it on GitHub.

jbenoit44 commented 9 years ago

Having a dance right now!! \m/ \m/

RodRecker commented 9 years ago

Send a video!

jnealb commented 9 years ago

@jbenoit44 @RodRecker La Bretonne, Farandole, Ritournelle, Bourrée ou la Gigue, venue d'Angleterre au 17eme siècle?

jbenoit44 commented 9 years ago

tumblr_static_tumblr_mjatuzs0lg1rb4km6o1_500

RodRecker commented 9 years ago

nice!