DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.72k stars 633 forks source link

Connectors lose connection after editing a custom or Formula node. #9908

Open ntikb opened 5 years ago

ntikb commented 5 years ago

Dynamo version

Dynamo core: 2.0.2.6826 Dynamo Revit: 2.0.2.6833

Revit version

2019.2.0.65

Operating system

Windows 10

What did you do?

Edit formula in a formula node. Same issue have been seen when editing other nodes as well.

What did you expect to see?

None other changes than the formula I edited.

What did you see instead?

The Formula node seems to be losing it before_editing_formula_node after_editing_formula_node lingering_connector

s input (one I created, which worked fine before editing). It looks as if the Formula node is still connected to the node providing the input, e.g. a GetParameterValue node. If I delete the Formula node, the connector from the GetParameterValue node is "hanging", not connected to anything.

Only solution (that I have found), is to copy/paste, in this case, both the formula node and the node providing the input, and then delete the faulty nodes.

I have seen this with other nodes as well, where several outputs, suddenly are connected to the same output.

Searching through existing threads handling the same topic, I found this from 2016. https://github.com/DynamoDS/DynamoRevit/issues/1163

Hopefully, I managed to describe a way to recreate the issue. I started a new thread, since both Dynamo and Revit versions are more recent than the ones used in found thread.

mjkkirschner commented 5 years ago

@ntikb this seems like a core issue, not specific to DynamoRevit - have you seen it in Dynamo sandbox?

you also see it with code block nodes?

Do you see it frequently - ie 100% of the time?

ntikb commented 5 years ago

So far, I only remember seeing it with Formula nodes. I tested in Dynamo Sandbox, and get the same issue. I tested in Dynamo Studio as well, and here it worked without problems.

I have not been able to recreate the problem using code blocks. The issue happens 100% of the time, including starting a new extremely simple script, containing only a code block and a formula node:

Before editing formula node: [cid:image001.png@01D4D435.F929AC00]

After editing formula node (changing the value 1500 to 1400): [cid:image002.png@01D4D435.F929AC00]

After deleting formula node: [cid:image003.png@01D4D435.F929AC00]

//Klaus

Fra: Michael Kirschner notifications@github.com Sendt: 4. marts 2019 17:19 Til: DynamoDS/DynamoRevit DynamoRevit@noreply.github.com Cc: Klaus Bang - NTI A/S KB@nti.dk; Mention mention@noreply.github.com Emne: Re: [DynamoDS/DynamoRevit] Connectors lose connection after editing a custom or Formula node. (#2353)

@ntikbhttps://github.com/ntikb this seems like a core issue, not specific to DynamoRevit - have you seen it in Dynamo sandbox?

you also see it with code block nodes?

Do you see it frequently - ie 100% of the time?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/DynamoDS/DynamoRevit/issues/2353#issuecomment-469314096, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AlX8bKcsiVAdgPBxPPnYb7_1fGycw1XRks5vTUeJgaJpZM4bUHGQ.

Amoursol commented 5 years ago

Closed issue as it's been migrated to the DynamoRevit issues repository.

aparajit-pratap commented 5 years ago

I am reopening this issue as I can reproduce it with sandbox plus other issues such as more than one connector going to the same input port: screenshot2