search

DynamoDS / DynamoDictionary

Apache License 2.0
8 stars 15 forks source link

Update Repo to use React 16 #38

Closed QilongTang closed 3 years ago

QilongTang commented 3 years ago

Update Dynamo Dictionary Repo to update from React 15 to React 16 for security requirements.

This includes updating to:

  1. react
  2. react-dom
  3. react-image-lightbox
  4. Adding react-router-dom dependency
  5. Removing react-tap-event-plugin

Issues found so far:

  1. Added missing npmrc file
  2. https://www.npmjs.com/package/react-tap-event-plugin no longer required after react 16.4
  3. hashHistory removed, see https://github.com/ReactTraining/react-router/issues/4752
  4. Link is now exported from react-router-dom, see example
  5. react-modal-bootstrap updated to use the version compatible with React 16

@Dewb @deepakanand I think I need some help from you guys, although the site now still builds but I cant seems to launch home page without error. I have very little experience debugging react before, would you take a look when you have time?

QilongTang commented 3 years ago

Looks like material-ui itself does not work with latest React so we have to upgrade that to material-ui/core..

QilongTang commented 3 years ago

The goal for this PR should be addressed by https://github.com/DynamoDS/DynamoDictionary/pull/55, if there are additional changes, will open more PRs for them.